FIX: Clean up in the new quiverkey test; make new figs in scale tests #7726
Conversation
Merging the new quiverkey test seemed to cause nondeterministic failures of test_log_scales and test_logit_scales. I couldn't reproduce but here's a guess: the new test creates a figure and doesn't close it, and the scale tests just call plt.subplot which would usually create a new figure but if the test gets executed right after the new test, they just add a subplot on the existing figure.
|
Woops, sorry for missing |
|
Definitely good changes. Any idea why we are still getting the svg image comparison failure in the py.test case? I've been seeing that, or a similar one with svg, quite frequently. |
|
No idea about that. Is it possible to see the output of the failing test case? |
|
I don't think so. Everything is done in a fresh virtualenv. I assume it is discarded as soon as the run is finished, and only the log from the run is provided. @tacaswell, is this correct? |
|
It seems that the test_scale.py failures happen consistently on Travis, even though I couldn't reproduce them locally. The svg failure seems unrelated to me (at least it's not the same mechanism where a Figure instance is left around from another test). I restarted the Travis build to see if the svg failure is just random. I think since this appears to help with the test_scale failures, it would be a good idea to merge it soon. |
Current coverage is 62.12% (diff: 100%)@@ master #7726 diff @@
==========================================
Files 174 174
Lines 56024 56036 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34799 34813 +14
+ Misses 21225 21223 -2
Partials 0 0
|
Merging the new quiverkey test seemed to cause nondeterministic
failures of test_log_scales and test_logit_scales. I couldn't reproduce
but here's a guess: the new test creates a figure and doesn't close it,
and the scale tests just call plt.subplot which would usually create
a new figure but if the test gets executed right after the new test,
they just add a subplot on the existing figure.