8000 Check at least one argument is provided for plt.table by dstansby · Pull Request #7522 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Check at least one argument is provided for plt.table #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2016
Merged

Check at least one argument is provided for plt.table #7522

merged 1 commit into from
Nov 28, 2016

Conversation

dstansby
Copy link
Member

Fixes #7519.

  • ValueError seemed to be the most suitable exception to raise, but I might be wrong.
  • Is it worth adding a test for this or not?

efiring
efiring approved these changes Nov 27, 2016
View reviewed changes
Copy link
Member
@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@efiring
Copy link
Member
efiring commented Nov 27, 2016

ValueError is appropriate. I do not think a test should be added for this.

@efiring efiring changed the title Check at least one argument is provided for plt.table [MRG+1] Check at least one argument is provided for plt.table Nov 27, 2016
@NelleV NelleV merged commit e0fcf3f into matplotlib:master Nov 28, 2016
@NelleV
Copy link
Member
NelleV commented Nov 28, 2016

Thanks @dstansby for the patch!

@QuLogic
Copy link
Member
QuLogic commented Nov 28, 2016

Backport?

@efiring
Copy link
Member
efiring commented Nov 28, 2016

Sure, go ahead.

QuLogic pushed a commit that referenced this pull request Dec 7, 2016
@NelleV @QuLogic
Merge pull request #7522 from dstansby/table-argcheck
aef8acd 
Check at least one argument is provided for plt.table
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Dec 7, 2016
@QuLogic QuLogic changed the title [MRG+1] Check at least one argument is provided for plt.table Check at least one argument is provided for plt.table Dec 7, 2016
@QuLogic
Copy link
Member
QuLogic commented Dec 7, 2016

Backported to v2.x as aef8acd.

@dstansby dstansby deleted the table-argcheck branch December 27, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @efiring @NelleV @QuLogic
0