Fix test docs build on Travis with Sphinx 1.3.0 Edit (Lock travis on 1.2.3 for now) #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the theme name to default or classic depending on the version of Sphinx used
|
I asked a question about this at the Sphinx group https://groups.google.com/forum/#!forum/sphinx-users |
|
This is not enough, There is also an issue with our plot directive. Removing warnings as errors also result in many additional warnings with failing build of figures not raised as errors. https://api.travis-ci.org/jobs/54071025/log.txt?deansi=true Perhaps it is better to nail Sphinx to 1.2.3 for the time being? |
|
👍 for nailing to sphinx 1.2.3 for now |
We have a few isseus with 1.3 that still needs to be fixed
3c30e96 to
5f4f974
Compare
|
That is done now. I have added #4215 to track getting it working with Sphinx 1.3.0 |
tacaswell
added a commit
that referenced
this pull request
Mar 12, 2015
CI : test docs build on Travis with Sphinx 1.3.0 Edit (Lock travis on 1.2.3 for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 1.3 was just released. This introduced a number of new warnings which caused a test failure and our docs to stop building since we treat warnings as errors.
The test failed due to a renamed theme. So I have changed the config to set the theme name depending on the Sphinx version. (This might need a backport to the color overhaul branch)
The docs fail with:
Which is treated as an error. This looks like a bug in Sphinx it self since according to http://sphinx-doc.org/config.html?highlight=html_domain_indices#confval-html_domain_indices a list should be fully legal
In the interest of having a functional Sphinx build I have disabled the warnings as errors until we can get to the bottom of this.