include PySide in qt4agg backend check #3387
Conversation
|
Here is alternative PR addressing the claimed issue of #3386 |
|
I think this is on the right track. It might benefit from a bit of style revision; I can't review it now. |
| result2 = backend_pyqt4_internal_check(self) | ||
| except CheckFailed: | ||
| if result1 == None: | ||
| raise |
There was a problem hiding this comment.
I guess this should something like:
raise CheckFailed("Neither PySide nor PyQt4 was found")
As it is now it will output "qt4agg: no [PyQt4 not found]" if neither PySide or PyQt4 is installed.
|
I think this looks sensible and I would like to have it merged. I have one inline comment about the output when neither library is installed but apart from that 👍 |
|
Thanks @jenshnielsen . That double check and the logic of failure modes boggled me more than I care to admit. I redid things a bit more than you suggested and I think the result is much better. |
|
Yes this version is much more clean. To me this is a definitely a significant improvement that makes all the different qt backends and libraries much easier to understand as well as fixing the bugs. Once travis is happy I will merge this. |
include PySide in qt4agg backend check
No description provided.