CI: Try skipping wx on py310 #29443
Closed
CI: Try skipping wx on py310 #29443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "are you installed" check is failing and printing a message. However, because the failure is on import loading shared objects, we still try to run tests against it. This is yet another example of the limitations of wheels.
|
It may also be worth sorting out how to try to uninstall what ever we tried to install if our checker fails. |
|
I spot checked that wx was not installed in a 3.10 run and was installed in a 3.11 run. |
See #29449 |
|
better handled by #29449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "are you installed" check is failing and printing a message. However, because the failure is on import loading shared objects, we still try to run tests against it.
This is yet another example of the limitations of wheels.
We probably should debug why wxpython broke (it could either be the wheels changed to newly require libnotify or that the system dependencies changed and we stopped getting it by chance), but in the interest of un-breaking CI this just turns off wx for py310.