Remove call to non-existent method _default_contains in Artist #28157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
May 1, 2024
QuLogic
approved these changes
May 1, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 1, 2024
…ault_contains in Artist
ksunden
added a commit
that referenced
this pull request
May 3, 2024
…157-on-v3.9.x Backport PR #28157 on branch v3.9.x (Remove call to non-existent method _default_contains in Artist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This is a follow-up from #25546, whihch removed the
_default_containsmethod.A similar change was made to several other classes, such as Axes and Figure,
however the call within Artist itself was not removed.
This has evidently not presented a problem to anybody (that we know of), since most
artists (that are used interactively at least) have their own
containsmethod.However, if one were to have an Artist without a contains instead of returning
False, {},you would get an AttributeError.
Considered adding a test, but opted not to initially. (Willing to be talked into doing so)
PR checklist