8000 DOC: add collection-fontsrecommended to dependencies by story645 · Pull Request #27282 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

DOC: add collection-fontsrecommended to dependencies #27282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

story645
Copy link
Member
@story645 story645 commented Nov 7, 2023

My latex and fonts have imploded and started deleting themselves and doing a minimal texlive install, I also needed ``collection-fontsrecommended` for the docs to not error out.

@story645 story645 added the Documentation: devdocs files in doc/devel label Nov 7, 2023
@story645 story645 added this to the v3.8-doc milestone Nov 7, 2023
@tacaswell
Copy link
Member

Could you tell from the error messages which font was missing? The packaging of latex stuff seems to vary significantly between ecosystem, could you also add a note which distro this naming is from?

@story645
Copy link
Member Author
story645 commented Nov 7, 2023

could you also add a note which distro this naming is from?

Texlive - this is using tlmgr, (ETA) but I'll clarify that it's a texlive package. Different distros have it too

@story645
Copy link
Member Author
story645 commented Nov 7, 2023

And all I got from the error messages was that fonts were just being very wonky (It probably didn't help that I forgot to rebuild the font-cache after installing a new font)

These are the types of errors I got though:

@story645
Copy link
Member Author
story645 commented Nov 8, 2023

rewrote to make clearer this is a latex distro packaging requirement

@QuLogic
Copy link
Member
QuLogic commented Nov 8, 2023

You can find an exact list at https://src.fedoraproject.org/rpms/python-matplotlib/blob/rawhide/f/python-matplotlib.spec#_95 though that's probably far too specific to list for users. But you might be able to convert those into the collections.

@story645
Copy link
Member Author
story645 commented Nov 8, 2023

Can I say that's out of scope for this PR and turn it into a good first issue for someone else?

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic merged commit 5ee79b7 into matplotlib:main Dec 11, 2023
Copy link
lumberbot-app bot commented Dec 11, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 5ee79b7d81f0c9ea9dcba69c5e8cac35f7d1c183
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27282: DOC: add collection-fontsrecommended to dependencies'
  1. Push to a named branch:
git push YOURFORK v3.8.x:auto-backport-of-pr-27282-on-v3.8.x
  1. Create a PR against branch v3.8.x, I would have named this PR:

"Backport PR #27282 on branch v3.8.x (DOC: add collection-fontsrecommended to dependencies)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Copy link
lumberbot-app bot commented Dec 11, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.2-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 5ee79b7d81f0c9ea9dcba69c5e8cac35f7d1c183
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27282: DOC: add collection-fontsrecommended to dependencies'
  1. Push to a named branch:
git push YOURFORK v3.8.2-doc:auto-backport-of-pr-27282-on-v3.8.2-doc
  1. Create a PR against branch v3.8.2-doc, I would have named this PR:

"Backport PR #27282 on branch v3.8.2-doc (DOC: add collection-fontsrecommended to dependencies)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@story645 story645 deleted the latex-win branch May 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0