10000 Changing _log.info to warnings.warn and importing the warnings module. by pedrompecanha · Pull Request #27073 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Changing _log.info to warnings.warn and importing the warnings module. #27073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changing _log.info to warnings.warn and importing the warnings module. #27073

wants to merge 2 commits into from
+5 −4

Conversation

pedrompecanha
Copy link
Contributor
@pedrompecanha pedrompecanha commented Oct 12, 2023 •
edited
Loading

PR summary

Changing the _log.info to warnings.warn when passing string-formatted numbers as data, closes #23422 as for now.

PR checklist

QuLogic
QuLogic requested changes Oct 16, 2023
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the discussion on #23422 was conclusive. @timhoffm @jklymak

@pedrompecanha
Copy link
Contributor Author

Yeah, they weren't. I thought not a lot of discussion was going to happen, that's why I opened the PR. But I believe opening the PR sparked the discussion again, as it made it more recent and fresh.

@timhoffm
Copy link
Member

Unfortunately, the decision is not conclusive yet. You are right that it stalled, but got revived through this PR 😄 . Let's wait, what #23422 brings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MNT]: User feedback should use warnings, not logs
4 participants
@pedrompecanha @timhoffm @QuLogic @melissawm
0