8000 Support standard formatters in axisartist. by anntzer · Pull Request #26586 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Support standard formatters in axisartist. #26586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

Support standard formatters in axisartist. #26586

merged 1 commit into from
Sep 27, 2023

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Aug 23, 2023 •
edited
Loading

Ideally, axisartist-specific formatters (and locators) should be deprecated and removed in the future.

Closes #18295 (see the modified test & baseline image for an example).

PR summary

PR checklist

oscargus
oscargus previously approved these changes Aug 24, 2023
View reviewed changes
@oscargus oscargus dismissed their stale review August 24, 2023 11:13

Didn't notice that the tests failed...

@anntzer
Support standard formatters in axisartist.
f699d50 
Ideally, axisartist-specific formatters (and locators) should be
deprecated and removed in the future.
@anntzer
Copy link
Contributor Author
anntzer commented Aug 24, 2023 •
edited
Loading

Indeed, fixed (some arch-dependent baseline image apparently...). Unfortunately there seems to remain a tiny bit of arch-dependent stuff which makes it impossible to have strictly the same baseline image on GHA CI and on Azure CI (setting tol to zero and having a passing test on GHA results in an image mismatch on Azure) so I left a tiny tol (less that previously) on the test.