8000 FIX: axes3d.scatter color parameter doesn't decrease in size for non-finite coordinate inputs. by artemshekh · Pull Request #26249 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: axes3d.scatter color parameter doesn't decrease in size for non-finite coordinate inputs. #26249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscargus merged 1 commit into from
Jul 16, 2023
Merged

FIX: axes3d.scatter color parameter doesn't decrease in size for non-finite coordinate inputs. #26249

oscargus merged 1 commit into from
Jul 16, 2023

Conversation

@artemshekh
Copy link
Contributor
@artemshekh artemshekh commented Jul 4, 2023

PR summary

axes3d.scatter handled only c function parameter with cook.delete_masked_points.
Add support for color parameter + test.

PR checklist

@melissawm melissawm added topic: mplot3d PR: bugfix Pull requests that fix identified bugs labels Jul 4, 2023
scottshambaugh
scottshambaugh approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor
@scottshambaugh scottshambaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Confirmed that this fixes the issue, and the added test fails prior to the fix.

@oscargus oscargus added this to the v3.8.0 milestone Jul 16, 2023
@oscargus oscargus merged commit 887b51e into matplotlib:main Jul 16, 2023
@2sn
Copy link
2sn commented Jul 16, 2023

Thanks!

@ksunden ksunden mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oscargus oscargus oscargus approved these changes

@scottshambaugh scottshambaugh scottshambaugh approved these changes

Assignees

No one assigned

Labels

PR: bugfix Pull requests that fix identified bugs topic: mplot3d

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

[Bug]: ax.scatter (projection='3d') - incorrect handling of NaN

5 participants

@artemshekh @2sn @oscargus @scottshambaugh @melissawm
0