10000 Minor style tweaks to freetype build. by anntzer · Pull Request #25142 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Minor style tweaks to freetype build. #25142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

Minor style tweaks to freetype build. #25142

merged 1 commit into from
Feb 3, 2023

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Feb 3, 2023

The main point is actually to get rid of the comment that "static linking on Windows is almost certainly broken"; this may have been true when this first came in in 2015 but now that the PyPI builds use that things should work just fine.

The rest is just small style changes.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
Minor style tweaks to freetype build.
cef0ad7 
The main point is actually to get rid of the comment that "static
linking on Windows is almost certainly broken"; this may have been true
when this first came in in 2015 but now that the PyPI builds use that
things should work just fine.

The rest is just small style changes.
@tacaswell tacaswell added this to the v3.8.0 milestone Feb 3, 2023
@ksunden ksunden merged commit c075ce0 into matplotlib:main Feb 3, 2023
@anntzer anntzer deleted the ft branch February 3, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
Build Maintenance
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @ksunden
0