8000 FIX: Handle stopped animation figure resize by greglucas · Pull Request #22561 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: Handle stopped animation figure resize #22561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2022
Merged

FIX: Handle stopped animation figure resize #22561

merged 1 commit into from
Feb 28, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

Disable all animated artists after the animation has stopped. Also, remove the resize callback from the animation framework.

Closes #12528

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@greglucas
FIX: Handle stopped animation figure resize
c6b3e20 
Disable all animated artists after the animation has stopped. Also
remove the resize callback from the animation framework.
@greglucas
Copy link
Contributor Author

I considered adding a test for this, but it only affects interactive mode and would be quite tricky to implement properly in subprocesses.

dopplershift
dopplershift approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@dopplershift dopplershift merged commit d0f36a9 into matplotlib:main Feb 28, 2022
@greglucas greglucas deleted the animation-blit-resize branch February 28, 2022 19:42
@QuLogic QuLogic added this to the v3.6.0 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Empty axes on draw after blitted animation finishes
4 participants
@greglucas @dopplershift @timhoffm @QuLogic
0