8000 move `_toolbar_2` from webagg_core to webagg by ianhi · Pull Request #22454 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

move _toolbar_2 from webagg_core to webagg #22454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2022
Merged

move _toolbar_2 from webagg_core to webagg #22454

merged 1 commit into from
Feb 12, 2022

Conversation

ianhi
Copy link
Contributor
@ianhi ianhi commented Feb 12, 2022

PR Summary

Applying diff from @anntzer in matplotlib/ipympl#426

I don't fully understand what's happening here but without this patch ipympl will break on main.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@ianhi @anntzer
move _toolbar_2 from webagg_core to webagg
4d552b4 
Co-Authored-By: Antony Lee <1322974+anntzer@users.noreply.github.com>
@ianhi ianhi mentioned this pull request Feb 12, 2022
Merged
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: toolbar labels Feb 12, 2022
@anntzer anntzer added this to the v3.6.0 milestone Feb 12, 2022
@greglucas greglucas merged commit f3a2d41 into matplotlib:main Feb 12, 2022
@greglucas greglucas removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 12, 2022
@ianhi ianhi deleted the webagg-toolbar branch February 12, 2022 16:13
@ianhi ianhi mentioned this pull request Apr 18, 2022
Closed
@tacaswell tacaswell mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
topic: toolbar
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ianhi @anntzer @greglucas
0