8000 Fix check for manager presence in blocking_input. by anntzer · Pull Request #21553 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix check for manager presence in blocking_input. #21553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2021
Merged

Fix check for manager presence in blocking_input. #21553

merged 1 commit into from
Nov 7, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 6, 2021

This was missed in 3ccc17b. Closes #21548.
Milestoning as 3.5 as this is a regression in 3.3 and the fix seems simple enough, but feel free to push to 3.6.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.5.0 milestone Nov 6, 2021
@timhoffm timhoffm merged commit 4a05bb4 into matplotlib:main Nov 7, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 7, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#21553: Fix check for manager presence in block…
8fcd3b1 
…ing_input.
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 7, 2021
Merged
@anntzer anntzer deleted the mn branch November 7, 2021 23:12
jklymak added a commit that referenced this pull request Nov 8, 2021
@jklymak
Merge pull request #21560 from meeseeksmachine/auto-backport-of-pr-21…
b41f8f4 
…553-on-v3.5.x

Backport PR #21553 on branch v3.5.x (Fix check for manager presence in blocking_input.)
@yingfhu
Copy link
yingfhu commented Nov 29, 2021 •
edited
Loading

lib/matplotlib/blocking_input.pyL86 should be
self.fig.canvas.manager

@anntzer anntzer mentioned this pull request Nov 29, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

[Bug]: blocking_input
4 participants
@anntzer @yingfhu @tacaswell @timhoffm
0