8000 Remove scalarmappable private update attributes by greglucas · Pull Request #19552 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove scalarmappable private update attributes #19552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

Remove scalarmappable private update attributes #19552

merged 1 commit into from
Mar 23, 2021

Conversation

greglucas
Copy link
Contributor

PR Summary

The updates to scalar mappable would only occur if the
array was updated. This meant that updating the vmin/vmax of
the sm's norm would not be propagated to the drawn artists. This
update removes the array update checks from scalar mappable to calculate
the colors regardless of updates to the array.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic
QuLogic reviewed Mar 2, 2021
View reviewed changes
@tacaswell tacaswell added this to the v3.5.0 milestone Mar 2, 2021
@greglucas greglucas force-pushed the mesh-norm-update branch 2 times, most recently from 93876e9 to bead92b Compare March 4, 2021 02:25
@greglucas greglucas mentioned this pull request Mar 18, 2021
Merged
5 tasks
@QuLogic QuLogic requested a review from efiring March 20, 2021 02:00
@greglucas
MNT: Remove scalarmappable private update attributes
ed6d92b 
The updates to scalar mappable would only take effect if the
array was updated. This meant that updating the vmin/vmax of
the sm's norm would not be propagated to the drawn artists. This
update removes the update checks from scalar mappable to calculate
the colors regardless of updates to the array.
@QuLogic QuLogic merged commit 9de78ea into matplotlib:master Mar 23, 2021
@greglucas greglucas deleted the mesh-norm-update branch March 23, 2021 13:15
@smartlixx smartlixx mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@greglucas @efiring @QuLogic @tacaswell
0