8000 Colorbar cleanups. by anntzer · Pull Request #17835 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Colorbar cleanups. #17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2020
Merged

Colorbar cleanups. #17835

merged 1 commit into from
Jul 4, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jul 4, 2020 •
edited
Loading
  • Remove unused colorbar private method _extended_N: This method appears
    to never ever have been used ever since it was added to the codebase.
  • Shorten a comment about a wishlist item, and delete commented code
    which is clearly similar to the uncommented one just above.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.4.0 milestone Jul 4, 2020
@anntzer
Colorbar cleanups.
aa387f8 
- Remove unused colorbar private method _extended_N: This method appears
  to never ever have been used ever since it was added to the codebase.
- Shorten a comment about a wishlist item, and delete commented code
  which is clearly similar to the uncommented one just above.
@anntzer anntzer changed the title Remove unused colorbar private method _extended_N. Colorbar cleanups. Jul 4, 2020
@efiring efiring merged commit 8c2fbda into matplotlib:master Jul 4, 2020
@anntzer anntzer deleted the cbarextn branch July 4, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: color/colorbar
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @efiring @timhoffm
0