8000 Make plt.{r,theta}grids act as setters even when all args are kwargs. by anntzer · Pull Request #16988 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Make plt.{r,theta}grids act as setters even when all args are kwargs. #16988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Make plt.{r,theta}grids act as setters even when all args are kwargs. #16988

merged 1 commit into from
Mar 31, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 31, 2020

I'm going to claim that silently ignoring kwargs was a bug and thus this
behavior can be changed with just a note, but no deprecation.

Closes #16982.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Make plt.{r,theta}grids act as setters even when all args are kwargs.
c8ccd84 
I'm going to claim that silently ignoring kwargs was a bug and thus this
behavior can be changed with just a note, but no deprecation.
@anntzer anntzer added this to the v3.3.0 milestone Mar 31, 2020
@timhoffm
Copy link
Member

I think we can make the signature more explicit by mapping

set_rgrids(self, radii, labels=None, angle=None, fmt=None, **kwargs

to

rgrids(self, radii=None, labels=None, angle=None, fmt=None, **kwargs)

@anntzer
Copy link
Contributor Author
anntzer commented Mar 31, 2020

feel free to open a PR (or even just push it here :-))

@timhoffm
Copy link
Member

Can do in a separate PR. Possibly adding kw-only restrictions.

@QuLogic QuLogic merged commit 439a122 into matplotlib:master Mar 31, 2020
@anntzer anntzer deleted the rthetagrids branch March 31, 2020 23:50
@timhoffm timhoffm mentioned this pull request May 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: changes topic: polar
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

pyplot.rgrids don't do anything
3 participants
@anntzer @timhoffm @QuLogic
0