10000 Cleanup animation examples. by anntzer · Pull Request #16225 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup animation examples. #16225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

Cleanup animation examples. #16225

merged 1 commit into from
Feb 7, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 14, 2020
  • For many examples init_func doesn't do much, the default initial
    state is just fine.
  • animate_decay is fairly naturally an infinite animation, so don't
    limit it artificially to 1000 frames; also there is no need to
    disable blitting as that's already the default... and in fact
    blit=True would work just as well, but let's not bother.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Cleanup animation examples.
d5e8182 
- For many examples init_func doesn't do much, the default initial
  state is just fine.
- animate_decay is fairly naturally an infinite animation, so don't
  limit it artificially to 1000 frames; also there is no need to
  disable blitting as that's already the default... and in fact
  blit=True would work just as well, but let's not bother.
@timhoffm timhoffm added this to the v3.3.0 milestone Feb 3, 2020
@dstansby dstansby merged commit c449ee4 into matplotlib:master Feb 7, 2020
@anntzer anntzer deleted the animex branch February 7, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @dstansby
0