Restart pgf's latex instance after bad latex inputs. #15969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Dec 18, 2019
| @@ -276,3 +277,14 @@ def test_pdf_pages_lualatex(): | |||
| pdf.savefig(fig) | |||
|
|
|||
| assert pdf.get_pagecount() == 2 | |||
|
|
|||
|
|
|||
| def test_tex_restart_after_error(): | |||
There was a problem hiding this comment.
Probably need to add
@needs_xelatex
@pytest.mark.backend('pgf')?
There was a problem hiding this comment.
I think only the first one (the backend will be autoswitched anyways), thanks.
... and also move the warning about pgf-to-stream not supporting raster images to when actually outputting a raster image (otherwise the warning is spurious, and affects e.g. test_tex_restart_after_error).
timhoffm
approved these changes
Dec 19, 2019
jklymak
approved these changes
Dec 19, 20
8000
19
|
Thank you all for working on this! |
|
You're welcome, thanks for pointing out the issue :) |
6 tasks
|
This is being backported in the above PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and also move the warning about pgf-to-stream not supporting raster
images to when actually outputting a raster image (otherwise the warning
is spurious, and affects e.g. test_tex_restart_after_error).
Closes #15968.
PR Summary
PR Checklist