10000 Cleanup major_minor_demo. by anntzer · Pull Request #14088 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup major_minor_demo. #14088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2019
Merged

Cleanup major_minor_demo. #14088

merged 1 commit into from
Apr 30, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 29, 2019

Not defining the formatters/locators as global variables goes well with
the admonition to not reuse them for multiple axises.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Apr 29, 2019
View reviewed changes
@anntzer
Cleanup major_minor_demo.
94a4083 
Not defining the formatters/locators as global variables goes well with
the admonition to not reuse them for multiple axises.
@timhoffm timhoffm merged commit 8d487d8 into matplotlib:master Apr 30, 2019
@anntzer anntzer deleted the major_minor_demo branch April 30, 2019 07:57
@timhoffm timhoffm added this to the v3.1.1 milestone Apr 30, 2019
@timhoffm
Copy link
Member

@meeseeksdev backport to v3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 30, 2019
@timhoffm
Backport PR matplotlib#14088: Cleanup major_minor_demo.
b3bff56
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 30, 2019
Merged
dstansby added a commit that referenced this pull request Apr 30, 2019
@dstansby
Merge pull request #14103 from meeseeksmachine/auto-backport-of-pr-14…
5a9d521 
…088-on-v3.1.x

Backport PR #14088 on branch v3.1.x (Cleanup major_minor_demo.)
@QuLogic QuLogic modified the milestones: v3.1.1, v3.1.0 May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic
0