8000 Update centered ticklabels example by timhoffm · Pull Request #13610 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Update centered ticklabels example #13610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2019
Merged

Update centered ticklabels example #13610

merged 2 commits into from
Mar 7, 2019

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Mar 6, 2019 •
edited
Loading

PR Summary

  • Actually centered the minor ticks (see comment).
  • Rewrote the description.

Old example

New example

timhoffm
timhoffm commented Mar 6, 2019
View reviewed changes
@QuLogic @timhoffm
Update examples/ticks_and_spines/centered_ticklabels.py
4dd06fb 
Co-Authored-By: timhoffm <2836374+timhoffm@users.noreply.github.com>
@ImportanceOfBeingErnest ImportanceOfBeingErnest added this to the v3.1-doc milestone Mar 7, 2019
@dstansby dstansby merged commit 2c54229 into matplotlib:master Mar 7, 2019
@timhoffm timhoffm deleted the example-centered_ticklabels branch March 7, 2019 16:31
@QuLogic
Copy link
Member
QuLogic commented Mar 8, 2019

@meeseeksdev backport to v3.1.x

Guess there's no doc branch to backport to yet...

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 8, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 8, 2019
@dstansby
Backport PR matplotlib#13610: Update centered ticklabels example
aa50fe8
@QuLogic QuLogic modified the milestones: v3.1-doc, v3.1.0 Mar 8, 2019
timhoffm added a commit that referenced this pull request Mar 8, 2019
@timhoffm
Merge pull request #13624 from meeseeksmachine/auto-backport-of-pr-13…
6bb5d92 
…610-on-v3.1.x

Backport PR #13610 on branch v3.1.x (Update centered ticklabels example)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@dstansby dstansby dstansby approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @QuLogic @dstansby @ImportanceOfBeingErnest
0