Add font to pyplot.xkcd() #13476
Merged
Add font to pyplot.xkcd() #13476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyplot doesn't recognise xkcd Script from https://github.com/ipython/xkcd-font since the font family is 'xkcd Script' and not just 'xkcd'. Added font to list of xkcd fonts.
tacaswell
approved these changes
Feb 21, 2019
|
Thanks @chrjen ! |
timhoffm
approved these changes
Feb 21, 2019
|
Thanks, and congratulations on your first contribution to matplotlib! Maybe see you back some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pyplot doesn't recognise xkcd Script from https://github.com/ipython/xkcd-font since the font family is 'xkcd Script' and not just 'xkcd'.
Would be nice if it did so added font to list of xkcd fonts.