Suppress chaining of cache lookup failure in color conversion. #13468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, something like
`scatter(range(4), range(4), c=np.arange(4).reshape((2, 2)))`
results in the following traceback:
```
Traceback (most recent call last):
File "matplotlib/lib/matplotlib/colors.py", line 173, in to_rgba
rgba = _colors_full_map.cache[c, alpha]
TypeError: unhashable type: 'numpy.ndarray'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "matplotlib/lib/matplotlib/axes/_axes.py", line 4289, in _parse_scatter_color_args
colors = mcolors.to_rgba_array(c)
File "matplotlib/lib/matplotlib/colors.py", line 284, in to_rgba_array
result[i] = to_rgba(cc, alpha)
File "matplotlib/lib/matplotlib/colors.py", line 175, in to_rgba
rgba = _to_rgba_no_colorcycle(c, alpha)
File "matplotlib/lib/matplotlib/colors.py", line 240, in _to_rgba_no_colorcycle
raise ValueError("RGBA sequence should have length 3 or 4")
ValueError: RGBA sequence should have length 3 or 4
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 4, in <module>
File "matplotlib/lib/matplotlib/pyplot.py", line 2826, in scatter
None else {}), **kwargs)
File "matplotlib/lib/matplotlib/__init__.py", line 1512, in inner
return func(ax, *map(sanitize_sequence, args), **kwargs)
File "matplotlib/lib/matplotlib/axes/_axes.py", line 4458, in scatter
get_next_color_func=self._get_patches_for_fill.get_next_color)
File "matplotlib/lib/matplotlib/axes/_axes.py", line 4302, in _parse_scatter_color_args
.format(nc=n_elem, xs=xsize, ys=ysize)
ValueError: 'c' argument has 2 elements, which is not acceptable for use with 'x' with size 4, 'y' with size 4.
```
At least the topmost failure, regarding cache lookup, is irrelevant to
the end user, so suppress it, which this commit does.
The middle traceback is mildly interesing, in case the user intended to
pass in RGBA but mis-shaped it; we may want to fold the message into the
scatter() error as well -- but that's not the object of this commit.
jklymak
approved these changes
Feb 19, 2019
timhoffm
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, something like
scatter(range(4), range(4), c=np.arange(4).reshape((2, 2)))results in the following traceback:
At least the topmost failure, regarding cache lookup, is irrelevant to
the end user, so suppress it, which this commit does.
The middle traceback is mildly interesing, in case the user intended to
pass in RGBA but mis-shaped it; we may want to fold the message into the
scatter() error as well -- but that's not the object of this commit.
PR Summary
PR Checklist