Remove colour specification from some examples #13391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Feb 8, 2019
| @@ -28,9 +28,9 @@ | |||
|
|
|||
| fig, ax = plt.subplots() | |||
| rects1 = ax.bar(ind - width/2, men_means, width, yerr=men_std, | |||
| color='SkyBlue', label='Men') | |||
| label='Men') | |||
There was a problem hiding this comment.
Maybe sexist, but one could argue that the colors had gender associations that help in reading the chart....
There was a problem hiding this comment.
The default colour cycle makes them different colours anyway: https://1164-74355158-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/statistics/barchart_demo.html#sphx-glr-gallery-statistics-barchart-demo-py
There was a problem hiding this comment.
Sure, but blue/light red have are often deemed masculine/feminine. OTOH, I don't really feel strongly we need to perpetuate that.
There was a problem hiding this comment.
I agree, which is why I removed the explicit colours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subset of #13369, only the ones where removing the colours altogether is fine in my opinion.