8000 Rewrite convert_to_string using std::string by QuLogic · Pull Request #13332 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Rewrite convert_to_string using std::string #13332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 1, 2019
Merged

Rewrite convert_to_string using std::string #13332

merged 4 commits into from
Feb 1, 2019

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jan 31, 2019

PR Summary

Then we don't have to worry about managing the buffer ourselves, such as #13288. I'm a bit bummed that we still need a try/catch in __add_number, but writing an auto-free pointer seems too much work.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Remove unnecessary pointer in __add_number.
0d7ebc1
@QuLogic
Rewrite convert_to_string using std::string.
2592cbc 
Then we don't have to worry about managing the buffer ourselves.
@QuLogic
Simplify convert_to_string's return value.
6c51794 
It either works or it doesn't. Any out-of-memory case would cause an
exception and be handled by CALL_CPP.
anntzer
anntzer reviewed Jan 31, 2019
View reviewed changes
@tacaswell tacaswell added this to the v3.1 milestone Feb 1, 2019
@tacaswell tacaswell merged commit f1366a3 into matplotlib:master Feb 1, 2019
@tacaswell
Copy link
Member

Thanks @QuLogic !

As much as I love python, the compiler checking types does make it easier to cope with API changes....

@QuLogic QuLogic deleted the std-string branch March 28, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @anntzer
0