MAINT: Correctly handle empty lists in zip unpacking in mplot3d.art3d #12927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeatherGod
approved these changes
Dec 3, 2018
|
Can we add a test so this would have failed the first PR? |
tacaswell
approved these changes
Dec 8, 2018
|
A test would be good, but if producing this state is too contrived I am fine with this going in without a test (it is not worse that it was!). |
|
@rth I took the liberty of pushing the requested test to your branch. I hope that's ok. |
|
Thanks, @timhoffm , I appreciate it. I was indeed not sure how to write that test. |
|
Ready to merge. (Not doing it myself yet in case somebody wants to check my test.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a possible bug introduced in my earlier PR #12883, detected by @WeatherGod in #12883 (review), where zip unpacking didn't correctly handle the case of empty lists.
It makes sense to add this specialized path in this case (with respect to the previous version), as zip unpacking is much faster, and those are performance sensitive parts of the code, as identified in #11577