8000 Validate rcParams["image.origin"]. by anntzer · Pull Request #12898 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Validate rcParams["image.origin"]. #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2018
Merged

Validate rcParams["image.origin"]. #12898

merged 1 commit into from
Nov 27, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 27, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 27, 2018
jklymak
jklymak approved these changes Nov 27, 2018
View reviewed changes
lib/matplotlib/rcsetup.py
@@ -1150,7 +1150,8 @@ def _validate_linestyle(ls):
'image.interpolation': ['nearest', validate_string],
'image.cmap': ['viridis', validate_string], # one of gray, jet, etc
'image.lut': [256, validate_int], # lookup table
'image.origin': ['upper', validate_string], # lookup table
'image.origin': ['upper',
ValidateInStrings('image.origin', ['upper', 'lower'])],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised you didn't wrap this in something that wasn't camel case 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have bigger plans for rcsetup, but they're shelved for now...

@timhoffm timhoffm merged commit 66126d9 into matplotlib:master Nov 27, 2018
@anntzer anntzer deleted the validate-image-origin-rc branch November 27, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: argument checking topic: rcparams
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
163A
0