8000 Remove unused variables by timhoffm · Pull Request #12829 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove unused variables #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2018
Merged

Remove unused variables #12829

merged 1 commit into from
Nov 24, 2018

Conversation

timhoffm
Copy link
Member

PR Summary

timhoffm
timhoffm commented Nov 18, 2018
View reviewed changes 8000
lib/matplotlib/__init__.py
@@ -822,7 +822,7 @@ def __setitem__(self, key, val):
"either import that binding first, or set the QT_API "
"environment variable.")
cbook.warn_deprecated(
"2.2", name=key, obj_type="rcparam", addendum=addendum)
version, name=key, obj_type="rcparam", addendum=addendum)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the hard-coded value.

timhoffm
timhoffm commented Nov 18, 2018
View reviewed changes
lib/matplotlib/patches.py
else:
verticesA, codesA = [], []
ddxA, ddyA = 0., 0.
verticesA, codesA, ddxA, ddyA = (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this way it's more clear that the whole block is just a conditional assignment of the four variables.