10000 Move toolmanager warning from logging to warning. by anntzer · Pull Request #12749 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Move toolmanager warning from logging to warning. #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

Move toolmanager warning from logging to warning. #12749

merged 1 commit into from
Nov 5, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 5, 2018

Using warnings.warn avoids emitting the warning once per Tool, i.e. a
dozen times at each invocation. (Yes, the system is experimental, we
got that part.)

Also update the warning message (Matplotlib 2.1 is long past).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Move toolmanager warning from logging to warning.
1b5fa40 
Using warnings.warn avoids emitting the warning once per Tool, i.e. a
dozen times at each invocation.  (Yes, the system is experimental, we
got that part.)

Also update the warning message (Matplotlib 2.1 is long past).
@anntzer anntzer added this to the v3.1 milestone Nov 5, 2018
@jklymak jklymak merged commit 2e65e40 into matplotlib:master Nov 5, 2018
@anntzer anntzer deleted the toolmanager-warning branch November 5, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
0