Delete some if __name__ == "__main__" clauses.
#12717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In offsetbox and mpl_axes, they are just examples (mpl_axes doesn't even call `show()`); if anything the examples belong in the examples/ directory but they don't look particularly worth moving there either. In rcsetup, the clause is checking that the defaults in rcParams don't get modified by the validators. If anything this should be a test, but it doesn't look like it mattered. I did fix `text.latex.preamble`, `pgf.preamble`, and `keymap.fullscreen` to be idempotent under the validator; now the only rcParam that gets changed is `savefig.bbox` (due to the presence of the "standard" / None synonym) but again this isn't a problem.
timhoffm
approved these changes
Nov 2, 2018
QuLogic
reviewed
Nov 2, 2018
| @@ -1115,7 +1115,7 @@ def _validate_linestyle(ls): | |||
| 'text.color': ['black', validate_color], | |||
| 'text.usetex': [False, validate_bool], | |||
| 'text.latex.unicode': [True, validate_bool], | |||
| 'text.latex.preamble': [[''], validate_stringlist], | |||
| 'text.latex.preamble': [[], validate_stringlist], | |||
There was a problem hiding this comment.
That's because matplotlib.rcsetup.validate_stringlist([""]) == [] (i.e. the default is actually stored as [], not [""]) so the code I deleted complained that the validator was not idempotent here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In offsetbox and mpl_axes, they are just examples (mpl_axes doesn't even
call
show()); if anything the examples belong in the examples/directory but they don't look particularly worth moving there either.
In rcsetup, the clause is checking that the defaults in rcParams don't
get modified by the validators. If anything this should be a test, but
it doesn't look like it mattered. I did fix
text.latex.preamble,pgf.preamble, andkeymap.fullscreento be idempotent under thevalidator; now the only rcParam that gets changed is
savefig.bbox(dueto the presence of the "standard" / None synonym) but again this isn't a
problem.
PR Summary
PR Checklist