Update HTML animation as slider is dragged #12387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f84e5af to
1c98739
Compare
QuLogic
approved these changes
Oct 4, 2018
|
I’ve tested this on IE 11, Microsoft Edge, Firefox, Chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently, HTML animations do not update while the slider is dragged. The update occurs only when the slider is released. This is because we are using the
onchangeevent. This PR switches to usingoninputso that we get continuous updates.Special handling of Internet Explorer <= 11 is done because it does not understand
oninputand itsonchangeworks like the W3C specifcation ofoninput.For details see https://www.impressivewebs.com/onchange-vs-oninput-for-range-sliders/
If someone wants to test the effect, here is some example code to create an animation. To test on different browsers you can simply open a binder instance and change between
oninputandonchangeusing the developer tools of the browser.