8000 Cleanup axislines style. by anntzer · Pull Request #12384 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup axislines style. #12384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

Cleanup axislines style. #12384

merged 1 commit into from
Oct 3, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 3, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Oct 3, 2018
View reviewed changes
lib/mpl_toolkits/axisartist/axislines.py
@@ -424,7 +428,8 @@ def new_fixed_axis(self, loc,
):

if axes is None:
warnings.warn("'new_fixed_axis' explicitly requires the axes keyword.")
warnings.warn(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be cbook._warn_external?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a separate PR (in the works) doing some massive change of warnings.warn to warn_external.

tim 8000 hoffm
timhoffm approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to CI pass.

@jklymak jklymak merged commit 5773e7d into matplotlib:master Oct 3, 2018
@jklymak jklymak added this to the v3.1 milestone Oct 3, 2018
@anntzer anntzer deleted the axisline-style branch October 3, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
0