8000 Slightly clarify some invalid shape exceptions for image data. by anntzer · Pull Request #12200 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Slightly clarify some invalid shape exceptions for image data. #12200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2018
Merged

Slightly clarify some invalid shape exceptions for image data. #12200

merged 1 commit into from
Sep 22, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 21, 2018

PR Summary

Just ran into a case where clarifying the invalid shapes a bit would have helped with the debugging :)
Also make the error messages consistent among themselves.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Sep 21, 2018
ImportanceOfBeingErnest
ImportanceOfBeingErnest approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member
@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine a lot of cases where such enhanced information in the error message is useful.

(Note that I won't merge, because some test is failing, although it doesn't seem related to this PR)

@QuLogic QuLogic merged commit 6b4048d into matplotlib:master Sep 22, 2018
@anntzer anntzer deleted the imageerrors branch September 22, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dstansby @ImportanceOfBeingErnest @QuLogic
0