DOC: fix API note about get_tightbbox #12186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets stick with PRs to master and backporting via the bot. It makes sense to do either lots of merge-ups (from 3.0.0-doc -> 3.0.x -> master) or to do lots of backports, but not both. I think we will still do occasional merges up (so that you can see tags from the master branch so versioneer works correctly) but use the backports as the primary way of moving things between branches. |
|
hmm, tried changing the base and that went...badly. |
9d2c9fb to
f3b97dd
Compare
|
Somehow that entry got removed from master. I think I've fixed it now for basing it on master... |
|
.. and hard cycling... |
timhoffm
approved these changes
Sep 20, 2018
doc/api/api_changes.rst
Outdated
| returned by `.matplotlib.axes.Axes.get_tightbbox`. | ||
|
|
||
| `.matplotlib.axes.Axes.get_tightbbox` adds a new kwarg ``bbox_extra_artists`` | ||
| to specify the manually list of artists on the axes to include in the |
There was a problem hiding this comment.
not a native speaker, but I feel the "manually" should either be an adjective rather than an adverb or be in another position in the sentence.
077a1c9 to
4e47eae
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 21, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 21, 2018
tacaswell
added a commit
that referenced
this pull request
Sep 21, 2018
…186-on-v3.0.0-doc Backport PR #12186 on branch v3.0.0-doc (DOC: fix API note about get_tightbbox)
NelleV
added a commit
that referenced
this pull request
Sep 21, 2018
…186-on-v3.0.x Backport PR #12186 on branch v3.0.x (DOC: fix API note about get_tightbbox)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Made against
3.0.0-doc, but not sure that is correct.master...See discsuiion on gitter. I forgot to mention in the API change for
axes.get_tightbboxthat we'd added a kwarg.PR Checklist