-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: update "Previous Whats New" for 2.2 with reference to cividis paper #12184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we usually update the What’s New log? This info would be great where the cividis colormap is discussed in the main docs. |
@jklymak I'm unsure, honestly. For what it's worth there are recent backport commits to the What's New of the 2.2.3 branch, and it would make sense to keep the two on par. It seems that the current colormap page discusses very little (if anything) about the perceptually uniform colormaps, so I figured I should intrude as little as possible with the citation update. That being said I'd certainly support adding a few paragraphs about Whenever I currently try to convince someone to use perceptually uniform colormaps I point them to the SciPy 2015 video. If there's a comparably instructive description on matplotlib.org I haven't found it yet. |
The Choosing colormaps tutorial doesn’t cover that? |
I guess there are plenty of links to material on color blindness, and a brief paragraph explaining the concept of perceptual uniformity. I guess I just miss a more hands-on explanation, similar to the comparisons in the scipy 2015 video or the cividis paper. Anyway, just to bring myself back on topic a bit, I guess there would be room to add a few words about cividis to the tutorial page. |
Sounds reasonable to me. I think that tutorial predated cividis so a section extolling it’s virtues or the advantage of perceptually uniform colormaps in general would be welcome. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
@tacaswell thanks for the merge. Quick question: should I close #12179 and instead do what MeeSeeks told me to do to keep the history as standard as possible? |
Lets leave #12179 open and ignore meeseeks here. Backports on moved documentation is never going to go smoothly.... |
Update the "Previously Whats New" for 2.2 with a reference to the now-published paper discussing cividis. I kept most of the original text (but added an accent to the name of the first author) and turned it into one long inline link pointing to the DOI of the paper published in PLoS ONE.
Same change as #12179 (that one for 2.2.3 backport, this one for master).