Properly declare the interactive framework for the qt4foo backends. #12157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something went wrong ... Please have a look at my logs. |
|
This seems pretty important as otherwise you can not use the qt4 backends at all... |
@tacaswell can you try to reissue the command ? I added some logging. The error make no sens, and may have been a race condition. (couldn't checkout master) |
|
@meseekdev backport to v3.0.x |
|
@meseeksdev backport to v3.0.x |
|
2x e (meeseeksdev) |
|
I need to find a better name, or a better trigger word. |
|
@meeseeksdev backport to v3.0.x |
|
third times the charm? |
|
Yep, currently clonning. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 19, 2018
…ork for the qt4foo backends.
dstansby
added a commit
that referenced
this pull request
Sep 19, 2018
…157-on-v3.0.x Backport PR #12157 on branch v3.0.x (Properly declare the interactive framework for the qt4foo backends.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Otherwise they think they need qt5. Probably worth going into the next bugfix release though it's unclear how urgent this is?
PR Checklist