Various cleanups. #12050
Merged
Various cleanups. #12050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 6, 2018
lib/matplotlib/mathtext.py
Outdated
| @@ -45,13 +45,17 @@ | |||
| # FONTS | |||
|
|
|||
| def get_unicode_index(symbol, math=True): | |||
| """get_unicode_index(symbol, [bool]) -> integer | |||
| r""" | |||
| Return the integer index (from the Unicode table) of *symbol* | |||
lib/matplotlib/mathtext.py
Outdated
| ---------- | ||
| symbol : str | ||
| A single unicode character, a TeX command (e.g. r'\pi') or a Type1 | ||
| symbol name (e.g. 'phi') |
- Document that in `margins()`, `tight` can be None, which is different from False (it keeps the previous setting). - Conversely, in two places, don't check for 'is True / is False', but just for normal truthiness. In particular, for the check on `get_clip_on()`, this is consistent with the check in `Artist.get_tightbbox()`. (Note that there are plently of other `is True` / `is False` checks in the codebase but they arise because the variable can also take some other values, e.g. a string or None.) - Fix a docstring.
|
comments handled |
NelleV
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
margins(),tightcan be None, which is differentfrom False (it keeps the previous setting).
just for normal truthiness. In particular, for the check on
get_clip_on(), this is consistent with the check inArtist.get_tightbbox(). (Note that there are plently of otheris True/is Falsechecks in the codebase but they arise because thevariable can also take some other values, e.g. a string or None.)
PR Summary
PR Checklist