Modernize ArtistInspector a bit... #12038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Sep 6, 2018
| @@ -11,22 +11,6 @@ | |||
| from .path import Path | |||
| from .transforms import (Bbox, IdentityTransform, Transform, TransformedBbox, | |||
| TransformedPatchPath, TransformedPath) | |||
| # Note, matplotlib artists use the doc strings for set and get | |||
There was a problem hiding this comment.
that comment is essentially completely false now (even the magic string for aliases is "Alias for", not "alias for" :))
timhoffm
approved these changes
Sep 6, 2018
lib/matplotlib/artist.py
Outdated
| else: | ||
| return s | ||
| return s + ''.join(' or %s' % x | ||
| for x in sorted(self.aliasd.get(s, []))) |
There was a problem hiding this comment.
Just to keep this structurally similar to alias_name_rest():
aliases = ''.join(' or %s' % x for x in sorted(self.aliasd.get(s, [])))
return s + aliases
Also slightly more readable.
lib/matplotlib/artist.py
Outdated
| ds = o.__doc__ | ||
| if ds is None: | ||
| return False | ||
| return ds.startswith('Alias for ') | ||
|
|
||
| def aliased_name(self, s): | ||
| """ | ||
| return 'PROPNAME or alias' if *s* has an alias, else return | ||
| PROPNAME. | ||
| return 'PROPNAME or alias' if *s* has an alias, else return PROPNAME. |
There was a problem hiding this comment.
May give it a capital to start, when you're editing anyway. 😄
|
comments handled |
|
Thanks @anntzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist