8000 Documentation mistake in pyplot.py corrected by surana-mudit · Pull Request #10055 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Documentation mistake in pyplot.py corrected #10055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2017
Merged

Documentation mistake in pyplot.py corrected #10055

merged 1 commit into from
Dec 21, 2017

Conversation

surana-mudit
Copy link
Contributor
@surana-mudit surana-mudit commented Dec 20, 2017 •
edited
Loading

Issue #10037

PR summary

I have corrected the documentation mistake in pyplot introductory tutorial

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.1.2 milestone Dec 20, 2017
@tacaswell
Copy link
Member

The docstring for subplot calls the third positional 'index',
(https://matplotlib.org/api/_as_gen/matplotlib.pyplot.subplot.html#matplotlib.pyplot.subplot ), might be slightly better to use that word instead.

@tacaswell
Copy link
Member

👍 and thank you for your work on this!

@dstansby
Copy link
Member

Thanks a lot @surana-mudit!

@dstansby dstansby merged commit febde4b into matplotlib:master Dec 21, 2017
lumberbot-app bot pushed a commit that referenced this pull request Dec 21, 2017
@dstansby
Backport PR #10055: Documentation mistake in pyplot.py corrected
f0c1a2e
@lumberbot-app lumberbot-app bot mentioned this pull request Dec 21, 2017
Merged
@dstansby dstansby mentioned this pull request Dec 21, 2017
Closed
jklymak added a commit that referenced this pull request Dec 21, 2017
@jklymak
Merge pull request #10070 from matplotlib/auto-backport-of-pr-10055
0cbed90 
Backport PR #10055 on branch v2.1.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects 47A6
None yet
Milestone
v2.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@surana-mudit @tacaswell @dstansby
0