8000 overhaul external process calls in TexManager · Issue #7490 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content
overhaul external process calls in TexManager #7490
Closed
@tacaswell

Description

@tacaswell

We see frequent transient failures for the TexManager in travis and http://stackoverflow.com/questions/40695296/strange-crash-after-saving-many-colormeshplots-using-matplotlib

I suspect what is going on here is that there is a race condition around the various system calls we are making. We capture the stdout from the various tex related processes, but do not caputer stderr (which I hope will have useful debugging information). We are using the (old) method of os.system. The suggested way to do this is now the subprocess module (https://www.python.org/dev/peps/pep-0324/). See https://docs.python.org/2/library/subprocess.html#replacing-os-system for comments on how to convert from os.system.

The specific tasks for this issue:

  • move from os.system to subprocess.call
  • capture stderr and include in exceptions

Tagging this as 'medium' difficulty because it is touching a rarely touched part of the code base and may require a good understanding of how subprocess calls work in python, but as new-contributor-friendly because it is a self-contained project on a relatively well tested set of functionality.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Difficulty: Mediumhttps://matplotlib.org/devdocs/devel/contribute.html#good-first-issues

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0