10000 Include test files in coverage report · Issue #6902 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content
Include test files in coverage report #6902
Closed
@Kojoley

Description

@Kojoley

Of course I can run coverage for tests locally, but I think it should be accessible on coveralls. You cannot blindly rely on a test report until you are sure that they are actually working, otherwise it could give you a false sense of security.

I have faced a problem where I cannot be sure that pytest runs all the tests. Moreover I have got a test failures with pytest on tests that nose does not perform (and I do not why then they are not deleted). Here is the list:

  • test_sankey not deprecated, runs without issues
  • test_skew not deprecated, has outdated baseline images or tolerance problems (..FF.F: RMS 0.014, 0.264, 0.065)
  • test_ttconv not deprecated, runs without issues
  • test_usetex not deprecated, has outdated baseline images or tolerance problems (.F: RMS 0.261)

What benefits can we have by including test files coverage in the report? I collected dark spots in the test suite:

Important (test not running, uncovered cases):

Less important (partial coverage):

Not important (requires tests for the tests, and other cases):

Someone can say that we need tests for the tests to have full coverage -- I would say no, some special places can be marked with #pragma: no cover, but other can be fixed to have full coverage.

Currently this can be done with nose-cov plugin and after migrating to pytest we will have exactly same coverage reports with pytest-cov.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0