10000 Image comparison decorator: symlinks to baseline images · Issue #6824 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Image comparison decorator: symlinks to baseline images #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kojoley opened this issue Jul 24, 2016 · 11 comments
Closed

Image comparison decorator: symlinks to baseline images #6824

Kojoley opened this issue Jul 24, 2016 · 11 comments
Labels
topic: testing
Milestone
v3.2.0

Comments

@Kojoley
Copy link
Member
Kojoley commented Jul 24, 2016

Currently image comparison decorator copies baseline image to result_images folder. Is not it better not to copy, but make symlink? With that change it still will be safe to remove result_images folder with rm -rf.
@jenshnielsen
Copy link
Member

Sounds reasonable to me. We just need to ensure that this still runs correctly on all platforms

@tacaswell
Copy link
Member
tacaswell commented Jul 26, 2016 •
edited
Loading

symlinks do not play well with windows

@Kojoley
Copy link
Member Author
Kojoley commented Jul 26, 2016

Matplotlib supports Windows XP? If not then Windows is not a problem.
Actually I have already developed cross-platform symlink support for image_comparison decorator with fallback to simple copy on unsupported platform, but it uses ctypes and gives not a big boost to testing time (around ~10 seconds)

@jenshnielsen
Copy link
Member

As far as I remember the main problem is with symlinks within git repositories. That should not apply here. I am not sure about windows xp. We have not deliberately broken support for it but it's also not really tested.

@Kojoley
Copy link
Member Author
Kojoley commented Jul 26, 2016

I had some problems with git and links, but they were hard links to files or symlinks to folders (because you can easily wipe your original folder or files). That does no apply here at least because result_images does not belong to git repository.

@tacaswell
Copy link
Member

As a non-windows user I am greatly confused why the issues with links apply to git, but not here?

@Kojoley If you work on windows and this works for you then 👍 to links instead of copying.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 26, 2016
@Kojoley
Copy link
Member Author
Kojoley commented Jul 26, 2016

Previously git-scm on windows was not aware of symlinks (from its point they were just regular files), so git checkout or git reset will give you no error and just replace/wipe content of symlinked file.

@Kojoley
Copy link
Member Author
Kojoley commented Jul 26, 2016

I do not know is it problem or not, but I think by default artifact tars will contain symlinks to baseline images (I believe there is some switches for this)

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Oct 3, 2017
@jbrockmendel
Copy link

Just discovered @image_comparison and its a nice feature, but I'd like to be able to specify where the created images will be placed. Creating a result_images images in my project's root directory is not welcome.

LMK if this belongs in a separate issue.

@tacaswell
Copy link
Member

@jbrockmendel You should have a look at pytest-mpl instead.

@tacaswell tacaswell modified the milestones: v2.2, v3.0 Dec 30, 2017
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Aug 11, 2018
@tacaswell tacaswell modified the milestones: v3.1.0, v3.2.0 Mar 18, 2019
@anntzer
Copy link
Contributor
anntzer commented Jul 4, 2019

done in #10222.

@anntzer anntzer closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
5 participants
@tacaswell @jenshnielsen @anntzer @Kojoley @jbrockmendel
0