ok... but I'm quite busy...

I also have an other comment about this function (when using a black and white color theme with inverted colors ie black background) it's quite problematic

we should also pass coloredgeup and coloredgedown parameter

def _candlestick(ax, quotes, width=0.2, colorup='g', colordown='r',                
                alpha=1.0, ochl=True, colorshadow='k', coloredgeup=None, coloredgedown=None):                

    """                
    Plot the time, open, high, low, close as a vertical line ranging                
    from low to high.  Use a rectangular bar to represent the                
    open-close span.  If close >= open, use colorup to color the bar,                
    otherwise use colordown                

    Parameters                
    ----------                
    ax : `Axes`                
        an Axes instance to plot to                
    quotes : sequence of quote sequences                
        data to plot.  time must be in float date format - see date2num                
        (time, open, high, low, close, ...) vs                
        (time, open, close, high, low, ...)                
        set by `ochl`                
    width : float                
        fraction of a day for the rectangle width                
    colorup : color                
        the color of the rectangle where close >= open                
    colordown : color                
         the color of the rectangle where close <  open                
    alpha : float                
        the rectangle alpha level                
    ochl: bool                
        argument to select between ochl and ohlc ordering of quotes                

    Returns                
    -------                
    ret : tuple                
        returns (lines, patches) where lines is a list of lines                
        added and patches is a list of the rectangle patches added                

    """                
    if coloredgeup is None:                
        coloredgeup = colorup                

    if coloredgedown is None:                
        coloredgedown = colordown                

    OFFSET = width / 2.0                

    lines = []                
    patches = []                
    for q in quotes: #[1:-1]:                
        if ochl:                
            t, open, close, high, low = q[:5]                
        else:                
            t, open, high, low, close = q[:5]                

        if close >= open:                
            color = colorup                
            coloredge = coloredgeup                
            lower = open                
            higher = close                
            height = close - open                
        else:                
            color = colordown                
            coloredge = coloredgedown                
            lower = close                
            higher = open                
            height = open - close                

        vline = Line2D(                
            xdata=(t, t), ydata=(low, lower),                
            color=colorshadow,                
            linewidth=0.5,                
            antialiased=True,                
        )                

        vline2 = Line2D(                
            xdata=(t, t), ydata=(higher, high),                
            color=colorshadow,                
            linewidth=0.5,                
            antialiased=True,                
        )                

        rect = Rectangle(                
            xy=(t - OFFSET, lower),                
            width = width,                
            height = height,                
            facecolor = color,                
            edgecolor = coloredge,                
        )                
        rect.set_alpha(alpha)                

        patches.append(rect)                
        lines.append(vline)                
        lines.append(vline2)                
        ax.add_patch(rect)                
        ax.add_line(vline)                
        ax.add_line(vline2)                
    #ax.autoscale_view()                

    return lines, patches

Uh oh!

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions