10000 [CI]: eslint failure · Issue #25251 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content
[CI]: eslint failure #25251
Closed
Closed
@scottshambaugh

Description

@scottshambaugh

Summary

Recent PRs are failing eslint linter checks with the following:

Run reviewdog/action-eslint@v1
Run $GITHUB_ACTION_PATH/script.sh
🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
 Running `npm install` to install eslint ...
eslint version:
/home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 20: Unknown: not found
 Running eslint with reviewdog 🐶 ...
  /home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 23: Unknown: not found
reviewdog: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token 
Error: Process completed with exit code 1.

Looks related to this: reviewdog/action-eslint#152

Proposed fix

The above issues proposes a workaround with:

      - uses: actions/setup-node@v3
         with:
           node-version: '18.13'
           cache: 'yarn'

However I’m unclear if pinning that version is best practice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CI: testingCI configuration and testing

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0