8000 [Bug]: CheckBoxes should be square, not rectangular · Issue #24471 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[Bug]: CheckBoxes should be square, not rectangular #24471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anntzer opened this issue Nov 15, 2022 · 4 comments · Fixed by #24474
Closed

[Bug]: CheckBoxes should be square, not rectangular #24471

anntzer opened this issue Nov 15, 2022 · 4 comments · Fixed by #24474
Labels
Difficulty: Medium https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! topic: widgets/UI
Milestone
v3.7.0

Comments

@anntzer
Copy link
Contributor
anntzer commented Nov 15, 2022

Bug summary

In #24428 I noted that RadioButtons used to be elliptical, and I fixed that in #24455 to make them circular while only emitting a deprecation warning if users tried to access the .circles attribute (and even then, they directly go back to the old behavior).

CheckButtons have the same issue: they are rectangular if the parent axes is not square. This issue can (most likely) be fixed in exactly the same manner as #24455 (see #24428 (comment)), preferably again keeping the backcompat layer and making things transparent to end users who don't try to access individual artists.

Tagging as good first issue it should(?) mostly be doing the same thing as #24455, but medium difficulty as you need to wrangle a bit with artists and transforms.

Code for reproduction

https://matplotlib.org/stable/gallery/widgets/check_buttons.html and make the window very wide

Actual outcome

Checkboxes become rectangular.

Expected outcome

They stay square.

Additional information

No response

Operating system

any

Matplotlib Version

3.7.0.dev691+g218cdffb53

Matplotlib Backend

any

Python version

3.10

Jupyter version

ENOSUCHLIB

Installation

git checkout
@anntzer anntzer added topic: widgets/UI Difficulty: Medium https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! labels Nov 15, 2022
@chahak13
Copy link
Contributor

This looks like a fun problem. Can I pick this up?

@story645
Copy link
Member

Go for it @chahak13!

@chahak13 chahak13 mentioned this issue Nov 16, 2022
Merged
6 tasks
@protocolog
Copy link

I am Student of BITS Pilani, India. Please assign me this issue.

@rcomer
Copy link
Member
rcomer commented Nov 25, 2022

Hi @protocolog thank you for your enthusiasm, but there is already an open pull request to address this issue at #24474.

@rcomer rcomer linked a pull request Nov 25, 2022 that will close this issue
Use scatter for check boxes and set facecolors correctly in check boxes and radio buttons #24474
Merged
6 tasks
@QuLogic QuLogic added this to the v3.7.0 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Medium https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! topic: widgets/UI
Projects
None yet
Milestone
v3.7.0
6 participants
@QuLogic @story645 @anntzer @rcomer @chahak13 @protocolog
0