8000 [TST] Upcoming dependency test failures · Issue #23084 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content
8000

[TST] Upcoming dependency test failures #23084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue May 21, 2022 · 5 comments · Fixed by #23130
Closed

[TST] Upcoming dependency test failures #23084

github-actions bot opened this issue May 21, 2022 · 5 comments · Fixed by #23130
Milestone
v3.6.0

Comments

@github-actions
Copy link

The weekly build with nightly wheels from numpy and pandas
has failed. Check the logs for any updates that need to be
made in matplotlib.
https://github.com/matplotlib/matplotlib/actions/runs/2361838774
@QuLogic
Copy link
Member
QuLogic commented May 24, 2022

Some of this is #23094, but also pytest appears to be attempting to load examples/*/*_test.py; possibly a change in 7.1.2.

@greglucas
Copy link
Contributor

It might be that now we're actually using the pytest.ini file created (#23044) and therefore we don't fallback to any other init files. Whereas before we were possibly hitting the Tests() extension in setup.py that specifies where the tests are found?

@QuLogic
Copy link
Member
QuLogic commented May 24, 2022

Oops, I misread the last pytest release as today, not last month. You're probably right about the pytest.ini, but it's odd that it overrides a setting that's not supplied.

@QuLogic
Copy link
Member
QuLogic commented May 24, 2022

I copied out the expected pytest.ini, and it does indeed collect the wrong files even in 7.0.1.

@greglucas
Copy link
Contributor

but it's odd that it overrides a setting that's not supplied.

I think we are actually overriding it in setup.py somewhat mysteriously IMO, and that was getting loaded before, but now that pytest found another initialization file it gladly doesn't listen to setup.py anymore...?

https://docs.pytest.org/en/6.2.x/customize.html#pytest-ini

pytest.ini files take precedence over other files, even when empty.

I'm not sure what the best way to fix this is: add our own default pytest.ini file? Put the contents of that warning to error stuff somewhere else? (although this is mysterious to me because I thought there was Numpy failures without that section before, which is why I put that in there, so it is odd that the tests were passing even when this ini file wasn't being used!).

@QuLogic QuLogic mentioned this issue May 25, 2022
Merged
2 tasks
@QuLogic QuLogic added this to the v3.6.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging a pull request may close this issue.

Drop pytest warning config in nightly tests QuLogic/matplotlib
2 participants
@QuLogic @greglucas
0