8000 Add ability to disable callbacks temporarily · Issue #20802 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add ability to disable callbacks temporarily #20802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greglucas opened this issue Aug 6, 2021 · 2 comments · Fixed by #20816
Closed

Add ability to disable callbacks temporarily #20802

greglucas opened this issue Aug 6, 2021 · 2 comments · Fixed by #20816
Labels
New feature
Milestone
v3.5.0

Comments

@greglucas
Copy link
Contributor

It may be useful to update some attributes on an object that has callbacks temporarily and we don't want those callback signals being processed during that time.

I guess we could add a disabling_callbacks() context manager on CallbackRegistry?

with self.norm.callbacks.disabling_callbacks(), cbook._setattr_cm(self.norm, ...): ...

Originally posted by @anntzer in #19553 (comment)
@timhoffm
Copy link
Member
timhoffm commented Aug 7, 2021

Naming suggestion: callbacks_disabled() or even only disabled():

with self.norm.callbacks.disabled():

@QuLogic
Copy link
Member
QuLogic commented Aug 9, 2021

In Qt, this is Widget->blockSignals, and in GTK, it is g_signal_handlers_block_*. Wx has a wxEventBlocker that you add on a widget to temporarily stop events. Not sure if Tk has anything similar.

IOW, it seems like 'block' is the common term for this for events, though I don't know if these callbacks qualify as 'events'.

@greglucas greglucas mentioned this issue Aug 10, 2021
Merged
6 tasks
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New feature
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging a pull request may close this issue.

ENH: Add the ability to block callback signals greglucas/matplotlib
3 participants
@QuLogic @timhoffm @greglucas
0