8000 LGTM no longer checks C code · Issue #17063 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content
LGTM no longer checks C code #17063
Closed
Closed
@QuLogic

Description

@QuLogic

A long time ago, our LGTM Check used to work with the C/C++ code, but it stopped doing so. Currently, this is because it runs setup.py using Python 2 and we have Python 3.6 syntax in it. We should be able to configure it to not use Python 2 easily.

However, prior to that, it failed because it could not download jQuery. I am working towards removing that requirement entirely, but this is something we should keep in mind if more things are downloaded (e.g., #16720).

And before anyone asks about the utility of LGTM, yes it's not blocking and full of many false positives, but I did go through it once and find several real bugs (e.g., #16802.) And since C/C++ is probably the language with least proficiency on the team, more eyes on it would be better.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0