8000 Merge pull request #7981 from story645/coding_guide · matplotlib/matplotlib@eeb5a76 · GitHub
[go: up one dir, main page]

Skip to content

Commit eeb5a76

Browse files
authored
Merge pull request #7981 from story645/coding_guide
Clarify backports documentation
2 parents 9e7e15b + 49a14f3 commit eeb5a76

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

doc/devel/coding_guide.rst

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,20 +90,23 @@ Backports
9090
When doing backports please include the branch you backported the
9191
commit to along with the SHA in a comment on the original PR.
9292

93-
Assuming we have ``matplotlib`` as a read-only remote to the
94-
matplotlib/matplotlib repo and ``DANGER`` as a read/write remote to
95-
the matplotlib/matplotlib repo, we do a backport from master to 2.x.
93+
We do a backport from master to v2.0.x assuming:
94+
95+
* ``matplotlib`` is a read-only remote branch of the matplotlib/matplotlib repo
96+
97+
* ``DANGER`` is a read/write remote branch of the matplotlib/matplotlib repo
98+
9699
The ``TARGET_SHA`` is the hash of the merge commit you would like to
97100
backport. This can be read off of the github PR page (in the UI with
98101
the merge notification) or through the git CLI tools.::
99102

100103
git fetch matplotlib
101-
git checkout v2.x
102-
git merge --ff-only matplotlib/v2.x
104+
git checkout v2.0.x
105+
git merge --ff-only matplotlib/v2.0.x
103106
git cherry-pick -m 1 TARGET_SHA
104-
gitk # to look at it
107+
git log --graph --decorate # to look at it
105108
# local tests? (use your judgment)
106-
git push DANGER v2.x
109+
git push DANGER v2.0.x
107110
# leave a comment on PR noting sha of the resulting commit
108111
# from the cherry-pick + branch it was moved to
109112

0 commit comments

Comments
 (0)
0