ENH have ax.get_tightbbox have a bbox around all artists

jklymak · jklymak · commit ec5756757085 · 2018-03-05T07:27:10.000-08:00
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -2211,8 +2211,29 @@ def get_tightbbox(self, renderer, bbox_extra_artists=None):
         `BboxBase` : containing the bounding box (in figure co-ordinates).
         """
 
-        bb = [artist for artist in self.get_children()
-                        if artist.get_visible()]
+        bb = []
+        if bbox_extra_artists is None:
+            artists = self.get_default_bbox_extra_artists()
+        else:
+            artists = bbox_extra_artists
+        for a in artists:
+            if isinstance(a, mlegend.Legend) and a.get_visible():
+                bb.append(a._legend_box.get_window_extent(renderer))
+            else:
+                bbox = a.get_window_extent(renderer)
+                if a.get_clip_on():
+                    clip_box = a.get_clip_box()
+                    if clip_box is not None:
+                        bbox = Bbox.intersection(bbox, clip_box)
+                    clip_path = a.get_clip_path()
+                    if clip_path is not None and bbox is not None:
+                        clip_path = clip_path.get_fully_transformed_path()
+                        bbox = Bbox.intersection(bbox,
+                                                 clip_path.get_extents())
+                if bbox is not None and (bbox.width != 0 or
+                                         bbox.height != 0):
+                    bb.append(bbox)
+
         for ax in self.axes:
             if ax.get_visible():
                 bb.append(ax.get_tightbbox(renderer, bbox_extra_artists))
